Remove schema alignment constraint from EquivalenceProperties::with_new_schema#20232
Open
Sahitya0805 wants to merge 3 commits intoapache:mainfrom
Open
Remove schema alignment constraint from EquivalenceProperties::with_new_schema#20232Sahitya0805 wants to merge 3 commits intoapache:mainfrom
Sahitya0805 wants to merge 3 commits intoapache:mainfrom
Conversation
Introduces a new SortOptions struct with fluent builder methods to eliminate boolean blindness in sort expressions. Changes: - Add SortOptions struct with desc(), asc(), nulls_first(), nulls_last() - Add Expr::sort_by() method accepting SortOptions - Keep existing Expr::sort() for backward compatibility - Add test demonstrating both old and new APIs Fixes apache#20227
Address review feedback to make the default values explicit instead of hiding them behind Self::default().
github-actions
bot
added
logical-expr
Author
|
Just following up on the PR I raised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18933.
This PR removes the strict schema alignment constraint from
EquivalenceProperties::with_new_schemaandOrderingEquivalenceClass::with_new_schema.Previously, these methods required schemas to be 'aligned' (same number of columns, same types at each position), which made it difficult to update properties when schemas evolved (e.g., in projections or join operations).
Key changes:
Added regression tests to verify renames, appends, and column removals.